zhjwpku commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2610043044
As @lidavidm is working on the type system, we seems to prefer Arrow-style, so I'm proposing we adopt Arrow's clang-tidy. There are two points I want to mention here: - I did not include `-modernize-avoid-c-arrays`, we can add this later when we really want the c array style - `-modernize-use-nodiscard` is include here, because we don't add [[nodiscard]] before the existing functions, I notice @lidavidm uses [[nodiscard]] in the type system code, so I'm wondering should we change all functions to this style? @wgtmac @lidavidm @pitrou what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
