zhjwpku commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2601912091
> I don't think we've had any major issues with our style conventions on Arrow C++. > > The only annoyance I have personally is the ambiguity around method naming, between `CamelCase` for most methods and `snake_case` for "cheap" accessors. I would rather a single method naming (and, coming from Python, I generally like `snake_case` the best, but that's just personal :) ). I'm wondering if the Arrow style enforced by CI rules or just committers enforce it while reviewing PRs? It seems not easy for a bot to tell whether a method is "cheap" or not, I might be wrong though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
