pitrou commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2612114917
> TBH, I'm not in favor of adding `[[nodiscard]]` every where. It is boring to type it for every function and make the function signature too verbose. How about only adding `[[nodiscard]]` to functions that will lead to fatal error if return values are discarded? I also think that it does not make sense to add `[[nodiscard]]` everywhere. It should only be used when ignoring the return value would be an error, for example if the return value itself is an error code :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
