rdblue commented on code in PR #12060:
URL: https://github.com/apache/iceberg/pull/12060#discussion_r1927532569
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -125,6 +126,18 @@ public class Parquet {
private Parquet() {}
+ public static void register() {
+ InternalData.register(FileFormat.PARQUET, Parquet::writeInternal,
Parquet::readInternal);
Review Comment:
I wanted to reduce the amount of reflection code so I thought it would make
sense to have the majority of this code in the format. We could load the
`writeInternal` and `readInternal` methods dynamically, I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
