stevenzwu commented on code in PR #11365: URL: https://github.com/apache/iceberg/pull/11365#discussion_r1862733192
########## format/view-spec.md: ########## @@ -97,7 +97,10 @@ Summary is a string to string map of metadata about a view version. Common metad View definitions can be represented in multiple ways. Representations are documented ways to express a view definition. -A view version can have more than one representation. All representations for a version must express the same underlying definition. Engines are free to choose the representation to use. +A view version can have more than one representation. All representations for a version must express the same underlying definition. Engines are free to choose the representation to use. For the table identifiers in the view definitions to be interoperable across engines, the following must be true: +* All engines must resolve a fully specified SQL identifier to the same table in the same catalog. Review Comment: > Typically default catalog is used when the catalog is omitted. When catalog is omitted, it also could be the case of using the same catalog where view is defined. @wmoustafa I feel here is the key part from Benny's suggestion ``` resolve to the same catalog and table ``` Benny's wording reads a little more clear to me because it specify the expected behavior under `when` condition. But I see your point. maybe it is better to add `same` to the description like ``` When table identifier omits the catalog name, then engines should use the *same* default-catalog or the view's catalog (which is allowed to be engine specific) and resolve to the same catalog and table. When table identifier omits the namespace, then engines should use the *same* default-namespace to resolve to the same catalog and table. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
