Fokko commented on issue #2: URL: https://github.com/apache/iceberg-cpp/issues/2#issuecomment-2522596132
I agree with what's been said before about keeping the set of dependencies as low as possible. Would it be possible to define the [`FileIO` interface](https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/io/FileIO.java) and let the dependent sub-project implement this (and have one implementation in tests of course)? The FileIO is [a pretty opinionated part](https://www.tabular.io/blog/iceberg-fileio-cloud-native-tables/) of Icebergs' design. During the query-planning process, Iceberg needs to be able to fetch manifests based on the evaluation of the metadata. Keep also in mind, that in Iceberg, the catalog often uses credential vending, where it will pass [certain properties](https://github.com/apache/iceberg/blob/38c8daa4eae8a75ab46571f1efce1609100f53dd/open-api/rest-catalog-open-api.yaml#L3193) to the `FileIO` to set credentials. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
