Fokko commented on code in PR #741:
URL: https://github.com/apache/iceberg-rust/pull/741#discussion_r1872785576
##########
crates/iceberg/src/writer/file_writer/mod.rs:
##########
@@ -37,11 +37,11 @@ pub trait FileWriterBuilder<O = DefaultOutput>: Send +
Clone + 'static {
/// The associated file writer type.
type R: FileWriter<O>;
/// Build file writer.
- fn build(self) -> impl Future<Output = Result<Self::R>> + Send;
+ fn build(self, schema: SchemaRef) -> impl Future<Output = Result<Self::R>>
+ Send;
Review Comment:
I'm a beginner rustacean, but you could still pass the `equality_config` to
the constructor, right?
And I agree with @liurenjie1024, I think in general we should think more
about the high-level API. For example, constructing the writers by yourself can
be pretty error-prone. Much rather I would see a `Table` object returning a
fully configured writer based on the current-schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
