liurenjie1024 commented on code in PR #741:
URL: https://github.com/apache/iceberg-rust/pull/741#discussion_r1872505571
##########
crates/iceberg/src/writer/file_writer/mod.rs:
##########
@@ -37,11 +37,11 @@ pub trait FileWriterBuilder<O = DefaultOutput>: Send +
Clone + 'static {
/// The associated file writer type.
type R: FileWriter<O>;
/// Build file writer.
- fn build(self) -> impl Future<Output = Result<Self::R>> + Send;
+ fn build(self, schema: SchemaRef) -> impl Future<Output = Result<Self::R>>
+ Send;
Review Comment:
Sorry, but I'm not convinced that this simplified things a lot. I think the
construction of writers will not be called directly by user, since they are low
level apis. Schema is only part of the arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
