ZENOTME commented on code in PR #741:
URL: https://github.com/apache/iceberg-rust/pull/741#discussion_r1868789693
##########
crates/iceberg/src/writer/mod.rs:
##########
@@ -83,13 +81,15 @@ pub trait IcebergWriter<I = DefaultInput, O =
DefaultOutput>: Send + 'static {
/// The current file status of iceberg writer. It implement for the writer
which write a single
/// file.
-pub trait CurrentFileStatus {
+pub trait CurrentWriterStatus {
/// Get the current file path.
fn current_file_path(&self) -> String;
/// Get the current file row number.
fn current_row_num(&self) -> usize;
/// Get the current file written size.
fn current_written_size(&self) -> usize;
+ /// Get the schema of the current file.
+ fn current_schema(&self) -> SchemaRef;
Review Comment:
This function will be useful in delta writer. But it's fine to remove for
now, let's add it until we find it's required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
