liurenjie1024 commented on code in PR #741:
URL: https://github.com/apache/iceberg-rust/pull/741#discussion_r1868671378
##########
crates/iceberg/src/writer/file_writer/mod.rs:
##########
@@ -37,11 +37,11 @@ pub trait FileWriterBuilder<O = DefaultOutput>: Send +
Clone + 'static {
/// The associated file writer type.
type R: FileWriter<O>;
/// Build file writer.
- fn build(self) -> impl Future<Output = Result<Self::R>> + Send;
+ fn build(self, schema: SchemaRef) -> impl Future<Output = Result<Self::R>>
+ Send;
Review Comment:
I don't understand, why this can't be passed as constructor parameter of the
`FileWriterBuilder`?
##########
crates/iceberg/src/writer/mod.rs:
##########
@@ -83,13 +81,15 @@ pub trait IcebergWriter<I = DefaultInput, O =
DefaultOutput>: Send + 'static {
/// The current file status of iceberg writer. It implement for the writer
which write a single
/// file.
-pub trait CurrentFileStatus {
+pub trait CurrentWriterStatus {
/// Get the current file path.
fn current_file_path(&self) -> String;
/// Get the current file row number.
fn current_row_num(&self) -> usize;
/// Get the current file written size.
fn current_written_size(&self) -> usize;
+ /// Get the schema of the current file.
+ fn current_schema(&self) -> SchemaRef;
Review Comment:
When this will be useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
