danielcweeks commented on code in PR #11704:
URL: https://github.com/apache/iceberg/pull/11704#discussion_r1871936645


##########
.palantir/revapi.yml:
##########
@@ -1145,6 +1145,134 @@ acceptedBreaks:
       new: "method org.apache.iceberg.BaseMetastoreOperations.CommitStatus 
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
         \ org.apache.iceberg.TableMetadata)"
       justification: "Removing deprecated code"
+  "1.7.0":

Review Comment:
   If we go the route of creating a new class, we might want to align the name 
with how we use this (e.g. `FileMappedData`, `FilePathMapper`, 
`LocationMapper`) as opposed to a what feels like a generic Map implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to