nastra commented on code in PR #11704:
URL: https://github.com/apache/iceberg/pull/11704#discussion_r1875488258
##########
.palantir/revapi.yml:
##########
@@ -1145,6 +1145,22 @@ acceptedBreaks:
new: "method org.apache.iceberg.BaseMetastoreOperations.CommitStatus
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
\ org.apache.iceberg.TableMetadata)"
justification: "Removing deprecated code"
+ "1.7.0":
+ org.apache.iceberg:iceberg-core:
+ - code: "java.method.returnTypeChanged"
Review Comment:
we can't change the return type of existing methods as it's breaking
existing APIs. We need to follow the same approach I mentioned earlier
(deprecated + introduce new methods with the new return type)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
