findepi commented on code in PR #11704:
URL: https://github.com/apache/iceberg/pull/11704#discussion_r1870996980
##########
.palantir/revapi.yml:
##########
@@ -1145,6 +1145,134 @@ acceptedBreaks:
new: "method org.apache.iceberg.BaseMetastoreOperations.CommitStatus
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
\ org.apache.iceberg.TableMetadata)"
justification: "Removing deprecated code"
+ "1.7.0":
Review Comment:
Thanks @nastra for commenting on this. I am fully aware of this and I know
this is justified in this case, but that's important to have an open
conversation about every API breakage.
I know why we have revapi and I know that we shouldn't break APIs.
OTOH, every entry in this file is a testimony that we sometimes can break
existing APIs, if there is a really good reason to do so.
Anyway, I am open to advice, how can we fix the `CharSequenceMap` without
API breakages.
Even a simple change to `CharSequenceMap.keySet` to make it return a view
per `Map.keySet` contract
(https://github.com/apache/iceberg/pull/11304#discussion_r1797751372) would be
an API breakage (although not one flagged by revapi).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
