Fokko commented on issue #2: URL: https://github.com/apache/iceberg-cpp/issues/2#issuecomment-2509645269
> What about creating yet another `iceberg::Field` to wrap `arrow::DataType` with better support of iceberg concepts? I think it should then wrap a `arrow: Field`, otherwise we would not be able to pass it into a [`arrow::Struct`](https://arrow.apache.org/docs/python/generated/pyarrow.struct.html). But now the struct returns `arrow:Field`, so then we should create a `iceberg::Struct` as well, otherwise we're casting all over the place. My biggest concern is that we have code all over the place to coerce the Arrow superset into the Iceberg types. To me, the Arrow system mixes both how it is encoded (`large_`) and the actual types, while a `Decimal` in Iceberg [should be encoded](https://github.com/apache/iceberg/blob/main/format/spec.md#parquet) as a `int32` when `P <= 9`. > If we have a clear interface of a FileIO, it shouldn't be too hard to make things pluggable. That's exactly what I meant, thanks for clarifying :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
