jbonofre commented on code in PR #11430:
URL: https://github.com/apache/iceberg/pull/11430#discussion_r1854047740
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestRowProjection.java:
##########
@@ -61,52 +63,63 @@ private RowData writeAndRead(String desc, Schema
writeSchema, Schema readSchema,
appender.add(row);
}
- Iterable<RowData> records =
+ Avro.ReadBuilder builder =
Avro.read(Files.localInput(file))
.project(readSchema)
- .createResolvingReader(FlinkPlannedAvroReader::create)
- .build();
+ .createReaderFunc(FlinkAvroReader::new);
+ if (useAvroPlannedReader) {
+ builder =
+ Avro.read(Files.localInput(file))
+ .project(readSchema)
+ .createResolvingReader(FlinkPlannedAvroReader::create);
+ }
+ Iterable<RowData> records = builder.build();
return Iterables.getOnlyElement(records);
}
- @Test
- public void testFullProjection() throws Exception {
+ @ParameterizedTest
+ @ValueSource(booleans = {false, true})
Review Comment:
@nastra by the way, I was confused about the expectation here because
`@TestTemplate` is not necessary at class level, it can be at method level too.
Actually both `@ParameterizedTest` and `@RepeatedTest` are based on
`@TestTemplate` (they use custom invocation context provider). That's why I was
confused (as `@ParameterizedTest` is actually a "specialized" `@TestTemplate`)
😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
