jbonofre commented on code in PR #11430:
URL: https://github.com/apache/iceberg/pull/11430#discussion_r1830478089
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/AbstractTestFlinkAvroReaderWriter.java:
##########
@@ -65,12 +63,13 @@ public class TestFlinkAvroReaderWriter extends DataTest {
Types.NestedField.optional(9, "decimal", Types.DecimalType.of(4,
2)));
@Override
- protected void writeAndValidate(Schema schema) throws IOException {
- List<Record> expectedRecords = RandomGenericData.generate(schema,
NUM_RECORDS, 1991L);
- writeAndValidate(schema, expectedRecords, NUM_RECORDS);
- }
+ protected abstract void writeAndValidate(Schema schema) throws IOException;
- private void writeAndValidate(Schema schema, List<Record> expectedRecords,
int numRecord)
+ void writeAndValidate(
+ Schema schema,
+ List<org.apache.iceberg.data.Record> expectedRecords,
Review Comment:
Afair, the reason is to avoid confusion with another `Record`. Let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
