nastra commented on code in PR #11430:
URL: https://github.com/apache/iceberg/pull/11430#discussion_r1858161532
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/AbstractTestFlinkAvroReaderWriter.java:
##########
@@ -65,12 +63,11 @@ public class TestFlinkAvroReaderWriter extends DataTest {
Types.NestedField.optional(9, "decimal", Types.DecimalType.of(4,
2)));
@Override
- protected void writeAndValidate(Schema schema) throws IOException {
- List<Record> expectedRecords = RandomGenericData.generate(schema,
NUM_RECORDS, 1991L);
- writeAndValidate(schema, expectedRecords, NUM_RECORDS);
- }
+ protected abstract void writeAndValidate(Schema schema) throws IOException;
Review Comment:
is there a particular reason why this is being made abstract now? It seems
both subclasses override and do the same thing as this method was doing
previously
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
