nastra commented on code in PR #11430:
URL: https://github.com/apache/iceberg/pull/11430#discussion_r1854033609
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestRowProjection.java:
##########
@@ -61,52 +63,63 @@ private RowData writeAndRead(String desc, Schema
writeSchema, Schema readSchema,
appender.add(row);
}
- Iterable<RowData> records =
+ Avro.ReadBuilder builder =
Avro.read(Files.localInput(file))
.project(readSchema)
- .createResolvingReader(FlinkPlannedAvroReader::create)
- .build();
+ .createReaderFunc(FlinkAvroReader::new);
+ if (useAvroPlannedReader) {
+ builder =
+ Avro.read(Files.localInput(file))
+ .project(readSchema)
+ .createResolvingReader(FlinkPlannedAvroReader::create);
+ }
+ Iterable<RowData> records = builder.build();
return Iterables.getOnlyElement(records);
}
- @Test
- public void testFullProjection() throws Exception {
+ @ParameterizedTest
+ @ValueSource(booleans = {false, true})
Review Comment:
`@TestTemplate` is for parameterization at the class level, which seems
exactly what's being done here. So rather than adding `@ValueSource` to each
single method it makes sense to do this at the class level and annotate all
tests with `@TestTemplate`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
