Acehaidrey commented on code in PR #11564:
URL: https://github.com/apache/iceberg/pull/11564#discussion_r1851153915
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -560,11 +560,13 @@ public Scan buildChangelogScan() {
}
boolean emptyScan = false;
+
if (startTimestamp != null) {
+ boolean isBeforeCurrentSnapshot =
table.currentSnapshot().timestampMillis() < startTimestamp;
startSnapshotId = getStartSnapshotId(startTimestamp);
- if (startSnapshotId == null && endTimestamp == null) {
- emptyScan = true;
- }
+ boolean hasNoValidStartSnapshot = startSnapshotId == null &&
endTimestamp == null;
+
+ emptyScan = isBeforeCurrentSnapshot || hasNoValidStartSnapshot;
Review Comment:
I'm okay with this as well!
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -560,11 +560,13 @@ public Scan buildChangelogScan() {
}
boolean emptyScan = false;
+
if (startTimestamp != null) {
+ boolean isBeforeCurrentSnapshot =
table.currentSnapshot().timestampMillis() < startTimestamp;
Review Comment:
thanks so much for the feedback, I'll incorporate what you mentioned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
