Acehaidrey commented on PR #11564: URL: https://github.com/apache/iceberg/pull/11564#issuecomment-2489802477
Fixed! Sorry I missed that On Wed, Nov 20, 2024 at 7:10 PM Yufei Gu ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestChangelogTable.java > <https://github.com/apache/iceberg/pull/11564#discussion_r1851144167>: > > > + + " 'start-timestamp', '%d'," > + + " 'end-timestamp', '%d'" > + + " )," > + + " changelog_view => 'test_changelog_view'" > + + ")", > + catalogName, tableName, startTime, endTime); > + > + // Query the changelog view > + List<Object[]> results = > + sql( > + "SELECT * FROM test_changelog_view WHERE _change_type IN ('INSERT', 'DELETE') ORDER BY _change_ordinal"); > + > + // Verify no changes are returned since our window is after the inserts > + assertThat(results).as("Num records must be zero").isEmpty(); > + > + > > nit: remove the extra empty line? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/11564#pullrequestreview-2449967049>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACPNAR6LLRHMGSZZRF5QD732BUQGXAVCNFSM6AAAAABR43PBQCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBZHE3DOMBUHE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
