Acehaidrey commented on code in PR #11564:
URL: https://github.com/apache/iceberg/pull/11564#discussion_r1851157822
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -560,11 +560,13 @@ public Scan buildChangelogScan() {
}
boolean emptyScan = false;
+
if (startTimestamp != null) {
+ boolean isBeforeCurrentSnapshot =
table.currentSnapshot().timestampMillis() < startTimestamp;
startSnapshotId = getStartSnapshotId(startTimestamp);
- if (startSnapshotId == null && endTimestamp == null) {
- emptyScan = true;
- }
+ boolean hasNoValidStartSnapshot = startSnapshotId == null &&
endTimestamp == null;
+
+ emptyScan = isBeforeCurrentSnapshot || hasNoValidStartSnapshot;
Review Comment:
@flyrain can you recheck the latest update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
