flyrain commented on code in PR #11564:
URL: https://github.com/apache/iceberg/pull/11564#discussion_r1851144167
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestChangelogTable.java:
##########
@@ -408,4 +408,53 @@ private List<Row> collect(DataFrameReader reader) {
.orderBy("_change_ordinal", "_commit_snapshot_id", "_change_type",
"id")
.collectAsList();
}
+
+ @TestTemplate
+ public void testChangelogViewOutsideTimeRange() {
+ createTableWithDefaultRows();
+
+ // Insert new records
+ sql("INSERT INTO %s VALUES (3, 'c')", tableName);
+ sql("INSERT INTO %s VALUES (4, 'd')", tableName);
+
+ Table table = validationCatalog.loadTable(tableIdent);
+ Snapshot insertSnapshot = table.currentSnapshot();
+
+ // Get timestamp after inserts but before our changelog window
+ long beforeWindowTime = System.currentTimeMillis();
+
+ // Small delay to ensure our timestamps are different
+ try {
+ Thread.sleep(100);
+ } catch (InterruptedException e) {
+ throw new RuntimeException("Test interrupted", e);
+ }
+
+ long startTime = System.currentTimeMillis();
+ long endTime = startTime + 1000; // 1 second window
+
+ // Create changelog view for a time window after our inserts
+ sql(
+ "CALL %s.system.create_changelog_view("
+ + " table => '%s', "
+ + " options => map("
+ + " 'start-timestamp', '%d',"
+ + " 'end-timestamp', '%d'"
+ + " ),"
+ + " changelog_view => 'test_changelog_view'"
+ + ")",
+ catalogName, tableName, startTime, endTime);
+
+ // Query the changelog view
+ List<Object[]> results =
+ sql(
+ "SELECT * FROM test_changelog_view WHERE _change_type IN
('INSERT', 'DELETE') ORDER BY _change_ordinal");
+
+ // Verify no changes are returned since our window is after the inserts
+ assertThat(results).as("Num records must be zero").isEmpty();
+
+
Review Comment:
nit: remove the extra empty line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
