RussellSpitzer commented on code in PR #11513:
URL: https://github.com/apache/iceberg/pull/11513#discussion_r1841271760
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -276,29 +215,25 @@ RewriteDataFilesCommitManager commitManager(long
startingSnapshotId) {
}
private Builder doExecute(
- RewriteExecutionContext ctx,
- Stream<RewriteFileGroup> groupStream,
- RewriteDataFilesCommitManager commitManager) {
+ RewritePlanResult planResult, RewriteDataFilesCommitManager
commitManager) {
ExecutorService rewriteService = rewriteService();
ConcurrentLinkedQueue<RewriteFileGroup> rewrittenGroups =
Queues.newConcurrentLinkedQueue();
Tasks.Builder<RewriteFileGroup> rewriteTaskBuilder =
- Tasks.foreach(groupStream)
+ Tasks.foreach(planResult.groups())
.executeWith(rewriteService)
.stopOnFailure()
.noRetry()
.onFailure(
- (fileGroup, exception) -> {
- LOG.warn(
- "Failure during rewrite process for group {}",
fileGroup.info(), exception);
- });
+ (fileGroup, exception) ->
+ LOG.warn(
Review Comment:
Not sure why this was changed? Did Spotless get more strict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
