pvary commented on code in PR #11513:
URL: https://github.com/apache/iceberg/pull/11513#discussion_r1836493600
##########
core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewriter.java:
##########
@@ -191,7 +191,7 @@ protected long inputSize(List<T> group) {
* of output files. The final split size is adjusted to be at least as big
as the target file size
* but less than the max write file size.
*/
- protected long splitSize(long inputSize) {
+ public long splitSize(long inputSize) {
Review Comment:
This is somewhat unrelated change - Flink will need to extract the split
size since in the Flink compaction implementation the planner which needs its
own rewriter, and the executor (where the rewriter is not used) runs on a
different instance.
We could put into the `FileGroupInfo`, but as a first run I opted for the
minimal change, especially on public APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
