RussellSpitzer commented on code in PR #11513:
URL: https://github.com/apache/iceberg/pull/11513#discussion_r1841270029
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -168,89 +160,36 @@ public RewriteDataFiles.Result execute() {
validateAndInitOptions();
- StructLikeMap<List<List<FileScanTask>>> fileGroupsByPartition =
- planFileGroups(startingSnapshotId);
- RewriteExecutionContext ctx = new
RewriteExecutionContext(fileGroupsByPartition);
+ RewritePlanResult result = plan(startingSnapshotId);
Review Comment:
minor nit here because we have a "result" variable which is not actually the
"result" of this function but is actually just an intermediary input. We could
probably change the class name to just RewritePlan and the variable to just plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
