JanKaul commented on issue #172: URL: https://github.com/apache/iceberg-rust/issues/172#issuecomment-2473365948
My two cents: I think it would make sense to list all requirements. The main requirements I can think of are: 1. Abstraction over different object stores 2. Harmonization of configuration specific to object storage If the mentioned requirements are the main motivation, I think it makes sense to use `ObjectStore` directly. I don't think there is value by wrapping an abstraction in another abstraction. And as people have stated before `ObjectStore` is a widely used rust library that has a nice integration with arrow/parquet/datafusion. Regarding 2: I think the common iceberg configuration could be handled with something like the existing [parse_url_opt](https://docs.rs/object_store/latest/object_store/fn.parse_url_opts.html) that parses a given iceberg configuration. This doesn't require a struct. In my opinion, the rest of the table configuration should be part of the table and not of FileIO. So for me it comes down to, what are the other requirements? And do they prohibit the use of a trait because of object safety. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
