rocco408 commented on PR #11419: URL: https://github.com/apache/iceberg/pull/11419#issuecomment-2471220679
Thanks again Russ, and Huaxin. I see where my previous attempt failed. In my last attempt I had swapped the placement of params to this `isPromotionAllowed(existingType, newType.asPrimitiveType())` which led me to update that method as well. Anywho, I understand what we're doing now, we're basically checking whether the `existingType` is wider then the `newType`, in which case we say we're compatible which results in ignoring an update. I'll tidy things up momentarily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
