rocco408 commented on PR #11419: URL: https://github.com/apache/iceberg/pull/11419#issuecomment-2466513581
This latest change to using TypeUtil.isPromotionAllowed() is failing a number of tests in TestSchemaUnionByFieldName. Further attempts to modify TypeUtil.isPromotionAllowed() and it's usage from UnionByNameVisitor are breaking other things like expectations of non-primitives to primitive conversions to throw exceptions. I think the issue is that TypeUtil.isPromotionAllowed() allows some things like list<string> -> string where we expect exceptions to be thrown elsewhere. I don't think we can use TypeUtil.isPromotionAllowed() without making more widespread updates elsewhere. I had actually considered updating TypeUtil.isPromotionAllowed() When I originally looked at this issue then decided not to touch it because of this reason. Open to thoughts whenever folks have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
