pan3793 commented on code in PR #11480:
URL: https://github.com/apache/iceberg/pull/11480#discussion_r1836979682
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala:
##########
@@ -151,6 +155,11 @@ class IcebergSparkSqlExtensionsParser(delegate:
ParserInterface) extends ParserI
isSnapshotRefDdl(normalized)))
}
+ private def isIcebergProcedure(normalized: String): Boolean = {
+ // All builtin Iceberg procedures are under the 'system' namespace
+ SparkProcedures.names().asScala.map("system." +
_).exists(normalized.contains)
Review Comment:
@RussellSpitzer the `normalized.startsWith("call") &&` is applied on the
caller side
I'm trying best to follow the existing `private def
isIcebergCommand(sqlText: String): Boolean` to organize the code -
`isSnapshotRefDdl` also does not contain `normalized.startsWith("alter table")
&&`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
