pan3793 commented on code in PR #11480:
URL: https://github.com/apache/iceberg/pull/11480#discussion_r1833619653
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCallStatementParser.java:
##########
@@ -68,11 +68,29 @@ public static void stopSpark() {
currentSpark.stop();
}
+ @Test
+ public void testDelegateUnsupportedProcedure() {
+ assertThatThrownBy(() -> parser.parsePlan("CALL cat.d.t()"))
+ .isInstanceOf(ParseException.class)
+ .hasMessageContaining("[PARSE_SYNTAX_ERROR] Syntax error at or near
'CALL'.");
Review Comment:
> In 4.0 we won't need this correct? One of the things I don't like about
this (but I don't think there is a fix in 3.5) is that Parse errors are very
uninformative.
@RussellSpitzer Yes, with SPARK-44167, Spark supports to parse the `CALL`
statement, and a `FAILED_TO_LOAD_ROUTINE` error class will be thrown for this
case.
@huaxingao thank you for information, will change soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
