pan3793 commented on code in PR #11480: URL: https://github.com/apache/iceberg/pull/11480#discussion_r1836983760
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/SparkProcedures.java: ########## @@ -37,6 +38,10 @@ public static ProcedureBuilder newBuilder(String name) { return builderSupplier != null ? builderSupplier.get() : null; } + public static Set<String> names() { + return BUILDERS.keySet(); Review Comment: to make it consistent with the existing method - the parameter name does not contain the `system.` prefix ``` public static ProcedureBuilder newBuilder(String name) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org