rcjverhoef commented on code in PR #11143:
URL: https://github.com/apache/iceberg/pull/11143#discussion_r1762019167
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2409,7 +2409,7 @@ public void testPaginationForListTables() {
RESTCatalog catalog =
new RESTCatalog(SessionCatalog.SessionContext.createEmpty(), (config)
-> adapter);
catalog.initialize("test",
ImmutableMap.of(RESTSessionCatalog.REST_PAGE_SIZE, "10"));
- int numberOfItems = 30;
+ int numberOfItems = 28;
Review Comment:
Same comment as below: The test case will work if and only if
`numberOfItems` is a multiple of the requested page size. Any test where that
is not the case and we request the last page will end in an
`IndexOutOfBoundsException`.
So I first changed this to consistently have the error, then fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
