rcjverhoef commented on code in PR #11143:
URL: https://github.com/apache/iceberg/pull/11143#discussion_r1762016389
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2347,7 +2347,7 @@ public void testPaginationForListNamespaces() {
RESTCatalog catalog =
new RESTCatalog(SessionCatalog.SessionContext.createEmpty(), (config)
-> adapter);
catalog.initialize("test",
ImmutableMap.of(RESTSessionCatalog.REST_PAGE_SIZE, "10"));
- int numberOfItems = 30;
+ int numberOfItems = 27;
Review Comment:
This test case only works if `numberOfItems % pageSize == 0`, where
`pageSize` is hardcoded to "10" in the line right above. Anything else will
show the error in the original paging code. That's why I first changed the
test, then fixed the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
