rahil-c commented on code in PR #11143:
URL: https://github.com/apache/iceberg/pull/11143#discussion_r1763957845
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2409,7 +2409,7 @@ public void testPaginationForListTables() {
RESTCatalog catalog =
new RESTCatalog(SessionCatalog.SessionContext.createEmpty(), (config)
-> adapter);
catalog.initialize("test",
ImmutableMap.of(RESTSessionCatalog.REST_PAGE_SIZE, "10"));
- int numberOfItems = 30;
+ int numberOfItems = 28;
Review Comment:
Thanks @rcjverhoef for the fix, as well as for the detailed explanation. i
think I agree that the main two test cases to try would be if its an exact
multiple and if it has some remainder. I think numbers between 21- 30
personally is not needed. So to me having `21` alone and `30` alone should
suffice.
cc @singhpk234 @amogh-jahagirdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
