rahil-c commented on code in PR #11143:
URL: https://github.com/apache/iceberg/pull/11143#discussion_r1761783152
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2409,7 +2409,7 @@ public void testPaginationForListTables() {
RESTCatalog catalog =
new RESTCatalog(SessionCatalog.SessionContext.createEmpty(), (config)
-> adapter);
catalog.initialize("test",
ImmutableMap.of(RESTSessionCatalog.REST_PAGE_SIZE, "10"));
- int numberOfItems = 30;
+ int numberOfItems = 28;
Review Comment:
I think maybe there may be some case @rcjverhoef is trying to test where the
page size is larger than the remaining items left in the result set. If so
maybe it might be better to keep the original `numberOfItems` for this test and
can add another test for this specific logic you are want to hit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
