kevinjqliu commented on code in PR #1029:
URL: https://github.com/apache/iceberg-python/pull/1029#discussion_r1711978272
##########
mkdocs/docs/configuration.md:
##########
@@ -84,6 +84,7 @@ For the FileIO there are several configuration options
available:
| s3.session-token | AQoDYXdzEJr... | Configure the static
session token used to access the FileIO.
|
| s3.signer | bearer | Configure the signature
version of the FileIO.
|
| s3.signer.uri | http://my.signer:8080/s3 | Configure the remote
signing uri if it differs from the catalog uri. Remote signing is only
implemented for `FsspecFileIO`. The final request is sent to
`<s3.singer.uri>/v1/aws/s3/sign`.
|
+| s3.signer.endpoint | v1/main/s3-sign | Configure the remote
signing endpoint. Remote signing is only implemented for `FsspecFileIO`. The
final request is sent to `<s3.singer.uri>/<s3.singer.endpoint>`. Default to
v1/aws/s3/sign`. |
Review Comment:
also s/s3.singer.endpoint/s3.signer.endpoint
##########
pyiceberg/io/__init__.py:
##########
@@ -58,6 +58,8 @@
S3_PROXY_URI = "s3.proxy-uri"
S3_CONNECT_TIMEOUT = "s3.connect-timeout"
S3_SIGNER_URI = "s3.signer.uri"
+S3_SIGNER_ENDPOINT = "s3.signer.endpoint"
+S3_SIGNER_ENDPOINT_DEFAULT_VALUE = "v1/aws/s3/sign"
Review Comment:
nit: convention is `S3_SIGNER_ENDPOINT_DEFAULT`
##########
mkdocs/docs/configuration.md:
##########
@@ -84,6 +84,7 @@ For the FileIO there are several configuration options
available:
| s3.session-token | AQoDYXdzEJr... | Configure the static
session token used to access the FileIO.
|
| s3.signer | bearer | Configure the signature
version of the FileIO.
|
| s3.signer.uri | http://my.signer:8080/s3 | Configure the remote
signing uri if it differs from the catalog uri. Remote signing is only
implemented for `FsspecFileIO`. The final request is sent to
`<s3.singer.uri>/v1/aws/s3/sign`.
|
+| s3.signer.endpoint | v1/main/s3-sign | Configure the remote
signing endpoint. Remote signing is only implemented for `FsspecFileIO`. The
final request is sent to `<s3.singer.uri>/<s3.singer.endpoint>`. Default to
v1/aws/s3/sign`. |
Review Comment:
what happens if im using pyarrow for fileio?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
