guitcastro commented on code in PR #1029:
URL: https://github.com/apache/iceberg-python/pull/1029#discussion_r1712144018
##########
mkdocs/docs/configuration.md:
##########
@@ -77,13 +77,14 @@ For the FileIO there are several configuration options
available:
<!-- markdown-link-check-disable -->
| Key | Example | Description
|
-| -------------------- | ------------------------ |
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
+| -------------------- | ------------------------
|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| s3.endpoint | https://10.0.19.25/ | Configure an alternative
endpoint of the S3 service for the FileIO to access. This could be used to use
S3FileIO with any s3-compatible object storage service that has a different
endpoint, or access a private S3 endpoint in a virtual private cloud. |
| s3.access-key-id | admin | Configure the static
access key id used to access the FileIO.
|
| s3.secret-access-key | password | Configure the static
secret access key used to access the FileIO.
|
| s3.session-token | AQoDYXdzEJr... | Configure the static
session token used to access the FileIO.
|
| s3.signer | bearer | Configure the signature
version of the FileIO.
|
-| s3.signer.uri | http://my.signer:8080/s3 | Configure the remote
signing uri if it differs from the catalog uri. Remote signing is only
implemented for `FsspecFileIO`. The final request is sent to
`<s3.singer.uri>/v1/aws/s3/sign`.
|
+| s3.signer.uri | http://my.signer:8080/s3 | Configure the remote
signing uri if it differs from the catalog uri. Remote signing is only
implemented for `FsspecFileIO`. The final request is sent to
`<s3.singer.uri>/<s3.singer.endpoint>`.
|
+| s3.signer.endpoint | v1/main/s3-sign | Configure the remote
signing endpoint. Remote signing is only implemented for `FsspecFileIO`. The
final request is sent to `<s3.singer.uri>/<s3.singer.endpoint>`. (default :
v1/aws/s3/sign). |
Review Comment:
Done, also renamed some in code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
