ZENOTME commented on code in PR #411:
URL: https://github.com/apache/iceberg-rust/pull/411#discussion_r1703074661
##########
crates/iceberg/src/avro/schema.rs:
##########
@@ -826,7 +914,117 @@ mod tests {
.unwrap()
};
- check_schema_conversion(avro_schema, iceberg_schema, false);
+ check_schema_conversion(avro_schema, iceberg_schema);
+ }
+
+ #[test]
+ fn test_schema_with_array_map() {
+ let avro_schema = {
+ AvroSchema::parse_str(
+ r#"
+{
+ "type": "record",
+ "name": "avro_schema",
+ "fields": [
+ {
+ "name": "optional",
+ "type": {
Review Comment:
> Can you add the element-id here as well?
I'm a little confused with this element id. Where is this element-id when we
convert this schema back to iceberg. We will convert this schema back to a map
in the schema so there is no place to use element-id. Or is it just a
placeholder?🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
