Fokko commented on code in PR #411:
URL: https://github.com/apache/iceberg-rust/pull/411#discussion_r1701781971
##########
crates/iceberg/src/avro/schema.rs:
##########
@@ -826,7 +914,117 @@ mod tests {
.unwrap()
};
- check_schema_conversion(avro_schema, iceberg_schema, false);
+ check_schema_conversion(avro_schema, iceberg_schema);
+ }
+
+ #[test]
+ fn test_schema_with_array_map() {
+ let avro_schema = {
+ AvroSchema::parse_str(
+ r#"
+{
+ "type": "record",
+ "name": "avro_schema",
+ "fields": [
+ {
+ "name": "optional",
+ "type": {
Review Comment:
Or maybe better, to add two new tests:
- One being an Avro map (not the `List` of `Structs` that's Iceberg specific
to have maps with keys other than strings)
- One being an Avro list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
