nk1506 commented on code in PR #10818:
URL: https://github.com/apache/iceberg/pull/10818#discussion_r1706519211
##########
common/src/main/java/org/apache/iceberg/common/DynConstructors.java:
##########
@@ -82,14 +76,6 @@ public <R> R invoke(Object target, Object... args) {
return (R) newInstance(args);
}
- @Override
- @SuppressWarnings("unchecked")
Review Comment:
I don't see any usage of this method. Since abstract method has been
removed. But we still have the
[invokeChecked](https://github.com/apache/iceberg/pull/10818/files#diff-bef8d1afda79d9ab9186f9fe726389f6dc25b17b1edc95756ab91f4131216e33R55)
method in use at super class.
Do you think we should safely remove this or mark it as deprecated for next
release ?
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
