findepi commented on code in PR #10818:
URL: https://github.com/apache/iceberg/pull/10818#discussion_r1706672859
##########
common/src/main/java/org/apache/iceberg/common/DynMethods.java:
##########
@@ -51,10 +51,8 @@ public static class UnboundMethod {
(method == null || method.isVarArgs()) ? -1 :
method.getParameterTypes().length;
}
- /** @deprecated since 1.6.0, will be removed in 1.7.0 */
- @Deprecated // will become private
@SuppressWarnings("unchecked")
- public <R> R invokeChecked(Object target, Object... args) throws Exception
{
+ private <R> R invokeChecked(Object target, Object... args) throws
Exception {
Review Comment:
> `// will become private`
my mistake
it was partially correct in a sense that it should stop being public API
but it seems i overlooked the fact the method is overridden (by
`DynConstructors.Ctor`) in a way changing the behavior (invoking Method vs
invoking a Constructor).
as such, it should become _package_-private, so that the override still works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
