nk1506 commented on code in PR #10818:
URL: https://github.com/apache/iceberg/pull/10818#discussion_r1697954569
##########
core/src/test/java/org/apache/iceberg/TestFileScanTaskParser.java:
##########
@@ -48,28 +40,6 @@ public void testNullArguments() {
.hasMessage("Invalid JSON string for scan task: null");
}
- @ParameterizedTest
- @ValueSource(booleans = {true, false})
- public void testFileScanTaskParser(boolean caseSensitive) {
- PartitionSpec spec = TestBase.SPEC;
- FileScanTask fileScanTask = createFileScanTask(spec, caseSensitive);
- String jsonStr = FileScanTaskParser.toJson(fileScanTask);
- assertThat(jsonStr).isEqualTo(fileScanTaskJsonWithoutTaskType());
- FileScanTask deserializedTask = FileScanTaskParser.fromJson(jsonStr,
caseSensitive);
- assertFileScanTaskEquals(fileScanTask, deserializedTask, spec,
caseSensitive);
- }
-
- /** Test backward compatibility where task-type field is absent from the
JSON string */
- @ParameterizedTest
- @ValueSource(booleans = {true, false})
- public void testFileScanTaskParserWithoutTaskTypeField(boolean
caseSensitive) {
Review Comment:
Already a
[test](https://github.com/apache/iceberg/blob/72b39ab91dfa04d713552e70b009c24510a1cd07/core/src/test/java/org/apache/iceberg/TestFileScanTaskParser.java#L65)
with new
[ScanTaskParser](https://github.com/apache/iceberg/blob/72b39ab91dfa04d713552e70b009c24510a1cd07/core/src/main/java/org/apache/iceberg/ScanTaskParser.java)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
