nastra commented on code in PR #10818:
URL: https://github.com/apache/iceberg/pull/10818#discussion_r1698087402


##########
.palantir/revapi.yml:
##########
@@ -1056,6 +1053,92 @@ acceptedBreaks:
     - code: "java.method.removed"
       old: "method org.apache.iceberg.DataFiles.Builder 
org.apache.iceberg.DataFiles.Builder::withEqualityFieldIds(java.util.List<java.lang.Integer>)"
       justification: "Deprecations for 1.6.0 release"
+    - code: "java.method.visibilityReduced"
+      old: "method void 
org.apache.iceberg.encryption.PlaintextEncryptionManager::<init>()"
+      new: "method void 
org.apache.iceberg.encryption.PlaintextEncryptionManager::<init>()"
+      justification: "Deprecations for 1.6.0 release"
+  "1.6.0":
+    org.apache.iceberg:iceberg-common:
+    - code: "java.element.noLongerDeprecated"
+      old: "method <R> R 
org.apache.iceberg.common.DynMethods.UnboundMethod::invokeChecked(java.lang.Object,\
+        \ java.lang.Object[]) throws java.lang.Exception"
+      new: "method <R> R 
org.apache.iceberg.common.DynMethods.UnboundMethod::invokeChecked(java.lang.Object,\
+        \ java.lang.Object[]) throws java.lang.Exception"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method <R> R 
org.apache.iceberg.common.DynConstructors.Ctor<C>::invokeChecked(java.lang.Object,\
+        \ java.lang.Object[]) throws java.lang.Exception"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method <R> R 
org.apache.iceberg.common.DynMethods.BoundMethod::invokeChecked(java.lang.Object[])\
+        \ throws java.lang.Exception"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method <R> R 
org.apache.iceberg.common.DynMethods.StaticMethod::invokeChecked(java.lang.Object[])\
+        \ throws java.lang.Exception"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method <T> org.apache.iceberg.common.DynFields.StaticField<T> 
org.apache.iceberg.common.DynFields.Builder::buildStaticChecked()\
+        \ throws java.lang.NoSuchFieldException"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method java.lang.Class<? extends C> 
org.apache.iceberg.common.DynConstructors.Ctor<C>::getConstructedClass()"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.common.DynConstructors.Builder 
org.apache.iceberg.common.DynConstructors.Builder::hiddenImpl(java.lang.Class<?>[])"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.common.DynMethods.Builder 
org.apache.iceberg.common.DynMethods.Builder::ctorImpl(java.lang.Class<?>,\
+        \ java.lang.Class<?>[])"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.common.DynMethods.Builder 
org.apache.iceberg.common.DynMethods.Builder::ctorImpl(java.lang.String,\
+        \ java.lang.Class<?>[])"
+      justification: "Removing deprecated method"
+    - code: "java.method.visibilityReduced"
+      old: "method <R> R 
org.apache.iceberg.common.DynMethods.UnboundMethod::invokeChecked(java.lang.Object,\
+        \ java.lang.Object[]) throws java.lang.Exception"
+      new: "method <R> R 
org.apache.iceberg.common.DynMethods.UnboundMethod::invokeChecked(java.lang.Object,\
+        \ java.lang.Object[]) throws java.lang.Exception"
+      justification: "Removing deprecated method"
+    org.apache.iceberg:iceberg-core:
+    - code: "java.class.removed"
+      old: "enum org.apache.iceberg.BaseMetastoreTableOperations.CommitStatus"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method java.lang.String 
org.apache.iceberg.FileScanTaskParser::toJson(org.apache.iceberg.FileScanTask)"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.FileScanTask 
org.apache.iceberg.FileScanTaskParser::fromJson(java.lang.String,\
+        \ boolean)"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.io.OutputFile 
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+        \ @ org.apache.iceberg.BaseOverwriteFiles"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.io.OutputFile 
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+        \ @ org.apache.iceberg.BaseReplacePartitions"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.io.OutputFile 
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+        \ @ org.apache.iceberg.BaseRewriteManifests"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.io.OutputFile 
org.apache.iceberg.SnapshotProducer<ThisT>::newManifestOutput()\
+        \ @ org.apache.iceberg.StreamingDelete"
+      justification: "Removing deprecated method"
+    - code: "java.method.removed"
+      old: "method void 
org.apache.iceberg.rest.auth.OAuth2Util.AuthSession::<init>(java.util.Map<java.lang.String,\
+        \ java.lang.String>, java.lang.String, java.lang.String, 
java.lang.String,\
+        \ java.lang.String, java.lang.String)"
+      justification: "Removing deprecated method"
+    - code: "java.method.returnTypeChanged"
+      old: "method 
org.apache.iceberg.BaseMetastoreTableOperations.CommitStatus 
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
+        \ org.apache.iceberg.TableMetadata)"
+      new: "method org.apache.iceberg.BaseMetastoreOperations.CommitStatus 
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
+        \ org.apache.iceberg.TableMetadata)"
+      justification: "Removing deprecated method"

Review Comment:
   can you update this message to `Removing deprecated code` instead of 
`method`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to