syun64 commented on code in PR #921:
URL: https://github.com/apache/iceberg-python/pull/921#discussion_r1677258384
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1407,7 +1408,7 @@ def list(self, list_type: ListType, list_array:
Optional[pa.Array], value_array:
# This can be removed once this has been fixed:
# https://github.com/apache/arrow/issues/38809
list_array = pa.LargeListArray.from_arrays(list_array.offsets,
value_array)
-
+ value_array = self._cast_if_needed(list_type.element_field,
value_array)
Review Comment:
These fixes are necessary to ensure that the types within ListTypes and
MapTypes are also promoted on write
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
