Fokko commented on code in PR #921:
URL: https://github.com/apache/iceberg-python/pull/921#discussion_r1677191050
##########
pyiceberg/schema.py:
##########
@@ -324,6 +324,11 @@ def field_ids(self) -> Set[int]:
"""Return the IDs of the current schema."""
return set(self._name_to_id.values())
+ @property
+ def field_names(self) -> Set[str]:
Review Comment:
Preferably I would not expose this field, since there are some issues with
it:
Conflicts with structs:
```
schema {
1: a.b string
2: a struct<1: b string>
}
```
Or with lists:
```
schema {
1: a.element string
2: a List<3: element string>
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
