kevinjqliu commented on code in PR #921:
URL: https://github.com/apache/iceberg-python/pull/921#discussion_r1677166736
##########
tests/integration/test_add_files.py:
##########
@@ -501,14 +501,11 @@ def test_add_files_fails_on_schema_mismatch(spark:
SparkSession, session_catalog
)
expected = """Mismatch in fields:
-┏━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━┓
-┃ ┃ Table field ┃ Dataframe field ┃
-┡━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━┩
-│ ✅ │ 1: foo: optional boolean │ 1: foo: optional boolean │
-| ✅ │ 2: bar: optional string │ 2: bar: optional string │
-│ ❌ │ 3: baz: optional int │ 3: baz: optional string │
-│ ✅ │ 4: qux: optional date │ 4: qux: optional date │
-└────┴──────────────────────────┴──────────────────────────┘
+┏━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┓
Review Comment:
I like the new way since it tells me exactly which field to focus on and the
reason its not compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
