Fokko commented on code in PR #921:
URL: https://github.com/apache/iceberg-python/pull/921#discussion_r1677431686
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1407,7 +1408,7 @@ def list(self, list_type: ListType, list_array:
Optional[pa.Array], value_array:
# This can be removed once this has been fixed:
# https://github.com/apache/arrow/issues/38809
list_array = pa.LargeListArray.from_arrays(list_array.offsets,
value_array)
-
+ value_array = self._cast_if_needed(list_type.element_field,
value_array)
Review Comment:
Ah good catch, we have those on the map, but the list is missing indeed 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
