Fokko commented on code in PR #886:
URL: https://github.com/apache/iceberg-python/pull/886#discussion_r1664804723
##########
mkdocs/docs/configuration.md:
##########
@@ -222,6 +222,12 @@ catalog:
uri: sqlite:////tmp/pyiceberg.db
```
+| Key | Example
| Default | Description
|
+| ------------- | ------------------------------------------------------------
| ------- |
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
+| uri | postgresql+psycopg2://username:password@localhost/mydatabase
| | SQLAlchemy backend URL for the catalog database (see [documentation
for URL
format](https://docs.sqlalchemy.org/en/20/core/engines.html#backend-specific-urls))
|
+| echo | true
| false | SQLAlchemy engine [echo
param](https://docs.sqlalchemy.org/en/20/core/engines.html#sqlalchemy.create_engine.params.echo)
to log all statements to the default log handler |
+| pool_pre_ping | true
| false | SQLAlchemy engine [pool_pre_ping
param](https://docs.sqlalchemy.org/en/20/core/engines.html#sqlalchemy.create_engine.params.pool_pre_ping)
to test connections for liveness upon each checkout |
Review Comment:
I have one more suggestion! Almost all of the configuration options are
using dashes (`-`), instead of underscores (`_`). Should we follow that
convention here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
