cccs-eric commented on code in PR #886:
URL: https://github.com/apache/iceberg-python/pull/886#discussion_r1664555741
##########
tests/catalog/test_sql.py:
##########
@@ -168,6 +168,39 @@ def test_creation_with_unsupported_uri(catalog_name: str)
-> None:
SqlCatalog(catalog_name, uri="unsupported:xxx")
+@pytest.mark.parametrize(
+ "echo_param, expected_echo_value",
+ [(None, strtobool(DEFAULT_ECHO_VALUE)), ("debug", "debug"), ("true",
True), ("false", False)],
Review Comment:
I can certainly do that, but I typically find that for-loops are often
hiding on which input the test is failing. You need to provide custom assert
messages or mentally figure out which input is triggering the failure. With
parameters, pytest will tell you right away which one is failing. But I
understand the overhead provided by parameterized test. Should I still go
ahead with the requested change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
