Fokko commented on code in PR #886:
URL: https://github.com/apache/iceberg-python/pull/886#discussion_r1666060990
##########
mkdocs/docs/configuration.md:
##########
@@ -222,6 +222,12 @@ catalog:
uri: sqlite:////tmp/pyiceberg.db
```
+| Key | Example
| Default | Description
|
+| ------------- | ------------------------------------------------------------
| ------- |
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
+| uri | postgresql+psycopg2://username:password@localhost/mydatabase
| | SQLAlchemy backend URL for the catalog database (see [documentation
for URL
format](https://docs.sqlalchemy.org/en/20/core/engines.html#backend-specific-urls))
|
+| echo | true
| false | SQLAlchemy engine [echo
param](https://docs.sqlalchemy.org/en/20/core/engines.html#sqlalchemy.create_engine.params.echo)
to log all statements to the default log handler |
+| pool_pre_ping | true
| false | SQLAlchemy engine [pool_pre_ping
param](https://docs.sqlalchemy.org/en/20/core/engines.html#sqlalchemy.create_engine.params.pool_pre_ping)
to test connections for liveness upon each checkout |
Review Comment:
Thanks, let's move this forward 🚀 Thanks @cccs-eric for the PR, and thanks
@kevinjqliu for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
